Update owo-colors (updated) #1708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to remove a transitive dependency on the deprecated `atty` crate, which trips `cargo deny` because it's unmaintained. This currently does not eliminate the dependency completely, as we're still waiting on `color-eyre` to release [1], and merging this PR as-is would result in `cargo deny` being even more angry at using different versions of the same crate, so this PR is a draft for now. The update is non-trivial because `owo-colors` no longer supports checking whether stdin supports colors, which is, well, reasonable. Semantically, this cements the `Stream` trait as something that can be printed onto, rather than a generic-purpose stream. Uses of `as_tty` are replaced with a direct call to the `std` `is_terminal` function, and `Stream` (now called `OwoStream`) now exclusively handles mapping `std` I/O streams to `owo-colors` streams. [1]: eyre-rs/eyre#215
neuschaefer
force-pushed
the
owo-updated
branch
2 times, most recently
from
3f58cdd to
4a4c322
Compare
The `adler` crate is now deprecated. The recommended replacement is `adler2`: https://rustsec.org/advisories/RUSTSEC-2025-0056 Update the minimal set of crates in order to remove adler, get adler2, and have one version of owo-colors.
neuschaefer
force-pushed
the
owo-updated
branch
from
4a4c322 to
8633ec6
Compare
Emilgardis
added
the
no-ci-targets
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #1611 and uses @purplesyringa's work mostly unmodified. In addition, I have updated the minimum set of crates to get to a working and consistent state, esp. w.r.t. cargo-deny.
I didn't update all the dependencies, in order to do "one thing at a time" and to avoid creating an undebuggable mess.