forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 52
Problem: repeated tx sender recovery is wastful #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yihuang
merged 5 commits into
crypto-org-chain:release/v0.20.x-cronos
from
yihuang:sender-cache
Mar 15, 2023
Merged
Problem: repeated tx sender recovery is wastful #227
yihuang
merged 5 commits into
crypto-org-chain:release/v0.20.x-cronos
from
yihuang:sender-cache
Mar 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: - only do once in ante handler, reuse the result
yihuang
commented
Mar 14, 2023
Signed-off-by: yihuang <[email protected]>
This was referenced Mar 14, 2023
mmsqe
reviewed
Mar 14, 2023
mmsqe
reviewed
Mar 14, 2023
Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]>
mmsqe
approved these changes
Mar 15, 2023
yihuang
commented
Mar 16, 2023
| } | ||
| var from common.Address | ||
| if len(msg.From) > 0 { | ||
| from = common.HexToAddress(msg.From) |
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// user can't set arbitrary value in From field in transaction, the SigVerify ante handler will verify the signature and recover the sender address and populate the From field, so the other code can use it directly when available.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)