Skip to content

Conversation

@yihuang
Copy link

@yihuang yihuang commented May 17, 2023

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@yihuang yihuang requested a review from mmsqe May 17, 2023 03:51
@yihuang yihuang marked this pull request as draft May 17, 2023 04:03
@yihuang yihuang force-pushed the release/v0.20.x-cronos branch from f74ccad to 95759c2 Compare May 26, 2023 03:36
@yihuang yihuang force-pushed the release/v0.20.x-cronos branch from 95759c2 to 4ba39b2 Compare May 26, 2023 03:37
@yihuang yihuang marked this pull request as ready for review May 26, 2023 03:38
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #246 (f74ccad) into release/v0.20.x-cronos (72bbe0a) will increase coverage by 4.12%.
The diff coverage is n/a.

❗ Current head f74ccad differs from pull request most recent head 4ba39b2. Consider uploading reports for the commit 4ba39b2 to get more accurate results

Impacted file tree graph

@@                    Coverage Diff                     @@
##           release/v0.20.x-cronos     #246      +/-   ##
==========================================================
+ Coverage                   52.56%   56.68%   +4.12%     
==========================================================
  Files                         113      108       -5     
  Lines                       11073    10243     -830     
==========================================================
- Hits                         5820     5806      -14     
+ Misses                       5006     4190     -816     
  Partials                      247      247              

see 5 files with indirect coverage changes

@yihuang yihuang requested review from mmsqe and removed request for mmsqe May 26, 2023 03:38
defer func() {
if tmNode.IsRunning() {
_ = tmNode.Stop()
_ = app.Close()

Check warning

Code scanning / gosec

Returned error is not propagated up the stack.

Returned error is not propagated up the stack.
@yihuang yihuang merged commit 0ea7b86 into crypto-org-chain:release/v0.20.x-cronos May 26, 2023
@yihuang yihuang deleted the release/v0.20.x-cronos branch May 26, 2023 07:07
mmsqe added a commit that referenced this pull request Jun 14, 2023
…wn (#246) (#275)

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>
Co-authored-by: yihuang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants