forked from evmos/ethermint
-
Notifications
You must be signed in to change notification settings - Fork 52
Problem: sender address verification is not decoupled from execution #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yihuang
merged 8 commits into
crypto-org-chain:develop
from
yihuang:parallel-sender-recovery
Sep 22, 2023
Merged
Problem: sender address verification is not decoupled from execution #358
yihuang
merged 8 commits into
crypto-org-chain:develop
from
yihuang:parallel-sender-recovery
Sep 22, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: #355 Solution: - to decouple sender address verification from execution, we must first enforce user setting the From field in the msg
yihuang
commented
Sep 22, 2023
| sdk.NewAttribute(sdk.AttributeKeySender, sender), | ||
| sdk.NewAttribute(types.AttributeKeyTxType, fmt.Sprintf("%d", tx.Type())), | ||
| sdk.NewAttribute(sdk.AttributeKeySender, types.HexAddress(msg.From)), | ||
| sdk.NewAttribute(types.AttributeKeyTxType, strconv.Itoa(int(tx.Type()))), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
Potential integer overflow by integer type conversion
mmsqe
reviewed
Sep 22, 2023
mmsqe
previously approved these changes
Sep 22, 2023
because many stores are never touched
mmsqe
reviewed
Sep 22, 2023
mmsqe
approved these changes
Sep 22, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WIP: #355
Solution:
Fromfield from string to bytes, avoid heavy checksum hex encoding of go-ethereumBenchmark Results
Run the
BenchmarkERC20Transferin cronos repo.For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)