forked from evmos/ethermint
    
        
        - 
                Notifications
    
You must be signed in to change notification settings  - Fork 52
 
Problem: sdk 0.52 is not used #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Draft
      
      
            mmsqe
  wants to merge
  85
  commits into
  crypto-org-chain:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
mmsqe:bump_sdk
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Draft
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    checked in StringToBytes
| gasBz := sdk.Uint64ToBigEndian(gas) | ||
| store.Set(types.KeyPrefixBlockGasWanted, gasBz) | ||
| if err := k.KVStoreService.OpenKVStore(ctx).Set(types.KeyPrefixBlockGasWanted, gasBz); err != nil { | ||
| panic(err) | 
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
      Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt
    
          Codecov ReportAttention: Patch coverage is  
 
 Additional details and impacted files@@             Coverage Diff             @@
##           develop     #568      +/-   ##
===========================================
- Coverage    46.17%   46.06%   -0.12%     
===========================================
  Files          181      181              
  Lines        18153    18253     +100     
===========================================
+ Hits          8383     8408      +25     
- Misses        9050     9110      +60     
- Partials       720      735      +15     
  | 
    
              
                    mmsqe
  
              
              commented
              
                  
                    Jan 8, 2025 
                  
              
              
            
            
      
        
      
      
  
    12 tasks
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)