photo tags interfere with most recent comments

[lodewiges]

It looks like adding a photo tag makes the photo go to the most recently edited photo. in the past there where only comments that did this. I don't think it is relevant to show an old picture that has new tags instead showing new comments is more interesting

Is this intended behavior?

Example:
order I first placed 3 comments from test 1 to test 3 after this I added a tag to the second photo this made it go to the first place.
Wanted behavior: the photo stays on the second place, this would mean that tags don't interfere with the order photo are shown

[wilco375]

I'm not sure I understand the description of this issue, can you explain the problem in more detail?
Also please note that this is a public repo, try not to include personal information like names and in this case comments someone made. You can create screenshots of the staging platform if needed.

[lodewiges]

maybe i am wrong by adding this feature to amber-api instead of amber-ui, it depends is we need a new database field to achieve this functionality.

[wilco375]

Ah I see, I was confused because as an oud-lid I cannot see photo comments, so the widget does not show up on my front page. It is likely a front-end issue (unless it also requires back-end modification to properly implement). Currently, the photos are sorted by updated_at date, which is modified both when a comment, or a tag is placed:

amber-ui/app/components/tools/recent-photos.js

Line 9 in 0a74842

return this.store.query('photo', {

We might instead want to get the latest comments, and then get the images associated with those.

[DrumsnChocolate]

Luckily, this bug still only seems to apply to photos that actually have comments. Meaning it's not just the most recently tagged photo that shows up on top, but instead the most recently tagged photo with comments.