[JUnit Platform Engine] Use FileSource.withPosition #3084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a `FileSource` involves a call to `File.getCanonicalFile`. This call can be slow because it involves the file system. Especially if the file system is networked. By using `FileSource.withPosition` we can reuse the canonical file from the feature for its nodes. Fixes: #3010
mpkorstanje
force-pushed
the
junit-platform-use-file-source-with-position
branch
from
44b67e1 to
8d5a508
Compare
mpkorstanje
commented
Sep 30, 2025
…le-source-with-position
…le-source-with-position # Conflicts: # CHANGELOG.md # cucumber-junit-platform-engine/pom.xml
mpkorstanje
deleted the
junit-platform-use-file-source-with-position
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Creating a
FileSourceinvolves a call toFile.getCanonicalFile. This call can be slow because it involves the file system. Especially if the file system is networked.By using
FileSource.withPositionwe can reuse the canonical file from the feature for its nodes.⚡️ What's your motivation?
Fixes: #3010
🏷️ What kind of change is this?
📋 Checklist: