v3: rubocop update #581
Merged
v3: rubocop update #581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on of rubocop-rails
lib/cucumber/rails.rb
Outdated
| else | ||
| warn "WARNING: Cucumber-rails required outside of env.rb. The rest of loading is being deferred | ||
| until env.rb is called. To avoid this warning, move 'gem \'cucumber-rails\', require: false' | ||
| until env.rb is called. To avoid this warning, move 'gem 'cucumber-rails', require: false' |
There was a problem hiding this comment.
Perhaps this became a little off, nesting single quote in single quote.
There was a problem hiding this comment.
Yep good spot. I'm not able to work on stuff much, but I think we should probably use a squiggly heredoc here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Now we're about to update to v3, we should get our ducks in a row regarding rubocop. We're miles behind (Primarily because of ruby version)
⚡️ What's your motivation?
Get suite more rubocop compliant, introduce new rubocop sub-gems e.t.c.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
This will get us slightly more compliant which is good thing for v3, any concerns about styling e.t.c.