Skip to content

Conversation

p8
Copy link
Contributor

@p8 p8 commented Sep 6, 2024

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

πŸ“‹ Checklist:

@olleolleolle
Copy link
Contributor

olleolleolle commented Sep 6, 2024

@p8 Awesome, I guess we need to land it in gemfile: ['rails_5_2', 'rails_6_0', 'rails_6_1', 'rails_7_0', 'rails_7_1']
too, in the darned CI workflow YAML.

@olleolleolle
Copy link
Contributor

olleolleolle commented Sep 6, 2024

Ah, right, some limits on Ruby/Rails versions for exclude/include

Because railties >= 7.2.0.beta1 depends on Ruby >= 3.1.0
  and rails_7_2.gemfile depends on railties ~> 7.2.1,
  Ruby >= 3.1.0 is required.
So, because current Ruby version is = 3.0.7,
  version solving has failed.

Thanks for chasing this!

Also add Ruby 3.3.
@p8
Copy link
Contributor Author

p8 commented Sep 6, 2024

@olleolleolle I've added Ruby 3.3 to the matrix as well.

@olleolleolle olleolleolle merged commit d10817f into cucumber:main Sep 6, 2024
15 checks passed
@olleolleolle
Copy link
Contributor

@p8 Thank you for this!

@p8 p8 deleted the rails-7-2 branch September 6, 2024 12:11
@p8
Copy link
Contributor Author

p8 commented Sep 6, 2024

Thanks @olleolleolle !

@luke-hill
Copy link
Contributor

Thanks for bringing this to my attention. Per the comments I need to do a bit of cleanup here. I'll get this done soon because it can just go in a patch release with some minor tidies I'll do in the codebase proper

@luke-hill luke-hill mentioned this pull request Sep 10, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants