Add support for more than 9 host entries per IP on Windows, fixes issue #74 #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for more than 9 host entries per IP on Windows, fixes issue #74
Changes to
libraries/entry.rbtaken from open PR #76 and updated to resolve merge conflicts.Integration tests not used from #76 as there are no windows platforms configured in test kitchen so the additional assertions will never be run. Added unit tests to
spec/unit/entry_spec.rbinstead. Manually tested with a windows kitchen suite, but not sure if this is possible to actually get working with dokken and travis.This is a similar PR to #76 and #80 but updated to resolve merge conflicts and including additional tests.