chart: fix generating extra ConfigMaps #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tpl invocation on (toYaml $value) breaks the rendered output by removing the newline character at the beginning the $value element. This commit factors out the tpl invocation to be called only on the actual data value, properly separating the ConfigMap's data entries.
Contributor
|
Is a new helm chart planned in the near term with this patch? |
Collaborator
Author
|
@jcpunk yes, I will publish a fix release probably tomorrow. |
gman0
added a commit
that referenced
this pull request
Aug 11, 2023
(Backport #105) chart: fix generating extra ConfigMaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tplinvocation on(toYaml $value)breaks the rendered output by removing the newline character at the beginning the$valueelement.This PR factors out the
tplinvocation to be called only on the actual data value, properly separating the ConfigMap's data entries.