automount: shut down automount with SIGKILL #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automount daemon unmounts the autofs root in /cvmfs upon receiving SIGTERM. This makes it impossible to reconnect the daemon to the mount later, so all consumer Pods will loose their mounts CVMFS, without the possibility of restoring them (unless these Pods are restarted too). The implication is that the nodeplugin is just being restarted, and will be needed again. SIGKILL is handled differently in automount, as this forces the daemon to skip the cleanup at exit, leaving the autofs mount behind and making it possible to reconnect to it later. We make a use of this, and unless the admin doesn't explicitly ask for cleanup with AUTOFS_TRY_CLEAN_AT_EXIT env var, no cleanup is done.
gman0
force-pushed
the
autofs-reconnect-fix
branch
from
d531272 to
f1d7ee2
Compare
gman0
added a commit
to gman0/cvmfs-csi
that referenced
this pull request
Sep 30, 2023
automount daemon unmounts the autofs root in /cvmfs upon receiving SIGTERM. This makes it impossible to reconnect the daemon to the mount later, so all consumer Pods will loose their mounts CVMFS, without the possibility of restoring them (unless these Pods are restarted too). The implication is that the nodeplugin is just being restarted, and will be needed again. SIGKILL is handled differently in automount, as this forces the daemon to skip the cleanup at exit, leaving the autofs mount behind and making it possible to reconnect to it later. We make a use of this, and unless the admin doesn't explicitly ask for cleanup with AUTOFS_TRY_CLEAN_AT_EXIT env var, no cleanup is done. Cherry-pick f1d7ee2 (cvmfs-contrib#122)
gman0
added a commit
that referenced
this pull request
Sep 30, 2023
(Backport #122) automount: shut down automount daemon with SIGKILL
|
I still have the mount disappeared from the pods on nodeplugin restart in v2.3.1 |
|
@dimm0 please open a new issue with logs attached, with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automount daemon unmounts the autofs root in /cvmfs upon receiving SIGTERM. This makes it impossible to reconnect
the daemon to the mount later, so all consumer Pods will loose their mounts CVMFS, without the possibility of restoring
them (unless these Pods are restarted too). The implication is that the nodeplugin is just being restarted, and will be
needed again.
SIGKILL is handled differently in automount, as this forces the daemon to skip the cleanup at exit, leaving the autofs
mount behind and making it possible to reconnect to it later. We make a use of this, and unless the admin doesn't explicitly ask for cleanup with
AUTOFS_TRY_CLEAN_AT_EXITenv var, no cleanup is done.Fixes #121