(Backport #123) automount-reconciler: consult only mount table and cvmfs_talk #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, after checking mount table and cvmfs_talk, the reconciler would also consult stat(). This has proven to be unreliable due to stale caches, and then making wrong decisions when to reconcile a mount. This resulted in reconcile delay that's larger than necessary. This commit removes the stat() call and makes the decision solely on results from cvmfs_talk as this seems sufficient. Cherry-pick 6d8cb56 (cvmfs-contrib#123)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, after checking mount table and cvmfs_talk, the reconciler would also consult stat(). This has proven to be unreliable due to stale caches, and then making wrong decisions when to reconcile a mount. This resulted in reconcile delay that's larger than necessary.
This commit removes the stat() call and makes the decision solely on results from cvmfs_talk as this seems sufficient.
Cherry-pick 6d8cb56 (#123)