Skip to content

Conversation

@petricm
Copy link
Collaborator

@petricm petricm commented Dec 18, 2020

The return code of cmvfs_config setup should be checked in the action as it is not the last command in the setup-cvmfs.sh script.

@petricm
Copy link
Collaborator Author

petricm commented Dec 18, 2020

I just realized there are situations like this

Reading package lists...
E: Failed to fetch http://cvmrepo.web.cern.ch/cvmrepo/apt/dists/bionic-prod/InRelease  403  Forbidden [IP: 137.138.31.235 443]
E: The repository 'http://cvmrepo.web.cern.ch/cvmrepo/apt bionic-prod InRelease' is not signed.
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package cvmfs
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package cvmfs-config-default
# cvmfs default.local file installed with cvmfs-contrib/github-action-cvmfs
CVMFS_CLIENT_PROFILE='single'
CVMFS_QUOTA_LIMIT='15000'
CVMFS_USE_CDN='yes'
Run cvmfs_config setup
sudo: cvmfs_config: command not found

which the action just passes through, while it should fail.

@petricm
Copy link
Collaborator Author

petricm commented Dec 18, 2020

and I think we should re-tag this into v2

Copy link
Collaborator

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I'll update the tag

@vvolkl vvolkl merged commit 9a82607 into cvmfs-contrib:main Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants