Skip to content

Conversation

@mimoning
Copy link
Contributor

@mimoning mimoning commented Oct 20, 2017

  • I ran npm test for the package I'm modifying

But something goes wrong! And I think that is not my fault…I don't know why

  • I used npm run commit instead of git commit

I can't find this command…

  • I have rebased my branch onto master before merging

Enable devServer port to customize. We can use PORT=xxxx npm start to run our app in a customized port.

@jvanbruegge jvanbruegge merged commit ff86550 into cyclejs-community:master Oct 20, 2017
@jvanbruegge
Copy link
Collaborator

Thanks for the PR, note however, if you want to be able to customize more, use the one-fits-all flavor, as it was designed for extension

@mimoning
Copy link
Contributor Author

OK👌,thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants