Skip to content

Conversation

youknowone
Copy link
Contributor

Getting unique path for image changing is useful, but missing feature (though it is able to be implemented in user side)

This patch includes breaking changes:

  • Any user customized store should add created_id argument to each put, get, delete methods
  • Any codes accessing to store url related api also should add created_id argument

@dahlia
Copy link
Owner

dahlia commented Jul 9, 2015

Does it purpose to invalidate client-side caching?

@youknowone
Copy link
Contributor Author

Yes. It seems there are cases not able to invalidate them with query strings.

@dahlia
Copy link
Owner

dahlia commented Jul 11, 2015

Is the problem caused by query string, or impossibility to determine when exactly things are updated?

@youknowone
Copy link
Contributor Author

Impossible to determine image is changed. The cache service is checking only the filenames.

@dahlia
Copy link
Owner

dahlia commented Jul 11, 2015

Okay. So there a trivial suggestion: passing an actual datetime value would be better than its encoded string representation, namely created_id. I think the better place of responsibility for how the created time has to be encoded is Store rather than Image. It gives more flexibility for supporting various store backends (for example, it can be used for providing Last-Modified header). What’s your opinion about this?

unique_url option is added to stores to decide enable this feature or
not.
@youknowone
Copy link
Contributor Author

Fixed

@dahlia dahlia force-pushed the master branch 2 times, most recently from 0c9948c to 3dcb35e Compare June 29, 2016 17:45
@dahlia dahlia force-pushed the master branch 3 times, most recently from 70d3ef3 to a8c74f9 Compare October 8, 2017 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants