Skip to content

Conversation

firewave
Copy link
Collaborator

Part of this code will go away again with #3229 but this makes sure the existing code actually works as expected.

…ot enabled / fixed and improved TestPreprocessor::inline_suppression_for_missing_include()
@firewave
Copy link
Collaborator Author

@danmar @amai2012

Since missingIncludeSystem was already potentially shadowed by the other warning I wonder if we should split them into two separate checks so you have more control over them. Usually you don't care about the missing system includes at all and Cppcheck works fine without them so you want to suppress the warning anyways.

And maybe missingInclude should be a warning instead of information since a missing local header has an effect on the analysis results and may even lead to false positives. So it is something we want the user to fix.

@firewave firewave marked this pull request as draft April 15, 2022 20:17
@firewave
Copy link
Collaborator Author

firewave commented Jul 9, 2022

This should be okay to merge for now.

@firewave firewave marked this pull request as ready for review July 9, 2022 20:42
@orbitcowboy orbitcowboy merged commit c363207 into danmar:main Jul 9, 2022
@firewave firewave deleted the missingInclude branch July 9, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants