check-library warns on access to a function call operator via an auto reference #4834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably not the right place to put that test, but I don't know any better
jmarrec
force-pushed
the
checkFunctionCallOperatorOverrideWithAutoReference
branch
from
208037e to
9c99a8f
Compare
jmarrec
commented
Feb 28, 2023
| " sVec.resize(1);\n" | ||
| " sVec(1).vec.resize(2);\n" | ||
| " sVec(1).vec(1) = 1.0;\n" | ||
| " S& thisS = sVec(1);\n" |
Contributor
Author
There was a problem hiding this comment.
This works when using the type explicitly.
Comment on lines
+2137
to
+2154
| check("template <typename T>\n" | ||
| "struct EPVector : public std::vector<T> {\n" | ||
| " using size_type = typename std::vector<T>::size_type;\n" | ||
| " [[nodiscard]] T& operator()(size_type n) { return (*this)[n - 1]; }\n" | ||
| " [[nodiscard]] const T& operator()(size_type n) const { return (*this)[n - 1]; }\n" | ||
| " void resize(size_type count) { std::vector<T>::resize(count); }\n" | ||
| "};\n" | ||
| "struct S { EPVector<double> vec; };\n" | ||
| "double f() {\n" | ||
| " EPVector<S> sVec;\n" | ||
| " sVec.resize(1);\n" | ||
| " sVec(1).vec.resize(2);\n" | ||
| " sVec(1).vec(1) = 1.0;\n" | ||
| " auto& thisS = sVec(1);\n" // NOTE: Using `auto&` instead of `S&` | ||
| " thisS.vec(2) = 2.0;\n" // TODO: --check-library: There is no matching configuration for function auto::vec() | ||
| " return sVec(1).vec(1) + thisS.vec(2);\n" // TODO: --check-library: There is no matching configuration for function auto::vec() | ||
| "}"); | ||
| ASSERT_EQUALS("", errout.str()); |
Contributor
Author
There was a problem hiding this comment.
this fails.
cppcheck/test/testfunctions.cpp:2154(TestFunctions::checkFunctionCallOperatorOverrideWithAutoReference): Assertion failed.
Expected:
Actual:
[test.cpp:15]: (information) --check-library: There is no matching configuration for function auto::vec()\n
[test.cpp:16]: (information) --check-library: There is no matching configuration for function auto::vec()\n
Here's a compiler explorer link showing that the code itself is fine: https://compiler-explorer.com/z/o7d6PzK6b
Collaborator
|
Thank you for your contribution. We are aware of this. There's still lots of false positive Some of them are already fixed by the pending #4824 and #4826. Or are being tracked by any of the tickets in the other PR. |
orbitcowboy
pushed a commit
that referenced
this pull request
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no clue how to fix it but I noticed something so I thought I'd create a test to see if you think it's a bug and if it's fixable.
This is probably not the right place to put that test, but I don't know any better.