Skip to content

Conversation

@chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github
Copy link
Collaborator Author

Is there a reason that unmatched suppressions are not reported in our selfcheck?

@danmar
Copy link
Owner

danmar commented Oct 11, 2023

Is there a reason that unmatched suppressions are not reported in our selfcheck?

I don't know. Spontanously, I believe we do want to report those.

Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@firewave
Copy link
Collaborator

Is there a reason that unmatched suppressions are not reported in our selfcheck?

There used to be since we had false positives. That might no longer be true. See #3090 for the PR which enables them.

@chrchr-github chrchr-github merged commit e247e81 into danmar:main Oct 11, 2023
@chrchr-github chrchr-github deleted the chr_Fix12052 branch October 11, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants