Clarify that main cannot be a getter
#1248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
commented
Oct 5, 2020
This was referenced Oct 5, 2020
lrhn
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@johnniwinther just noted that the wording about errors on
mainintroduced by #1146 needs to be clarified: It is not the intention thatmaincan be a getter (and the old text says so explicitly in commentary), but the wordfunctionin the spec refers to "functions" (with a<formalParameterPart>) as well as setters, getters, and constructors.In the context we already know that
mainis a top-level declaration, so it can't be a constructor. It can't be a setter because a setter name ends in=. So we just need to specify that it can't be a getter. This PR does that.