Skip to content

Format like count number #8344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Format like count number #8344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/lib/frontend/templates/views/pkg/labeled_scores.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ d.Node labeledScoresNode({
children: [
d.div(
classes: ['packages-score', 'packages-score-like'],
child: _labeledScore('likes', likeCount.toString(), sign: ''),
child: _labeledScore(
'likes',
'${compactFormat(likeCount).value}'
'${compactFormat(likeCount).suffix}',
sign: ''),
),
d.div(
classes: ['packages-score', 'packages-score-health'],
Expand Down
11 changes: 9 additions & 2 deletions app/lib/frontend/templates/views/pkg/score_tab.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,16 @@ d.Node _toolEnvInfoNode(List<_ToolVersionInfo> values) {
}

d.Node _likeKeyFigureNode(int? likeCount) {
// TODO: implement k/m supplemental for values larger than 1000
if (likeCount == null) {
return _keyFigureNode(
value: '--',
supplemental: '',
label: 'likes',
);
}
return _keyFigureNode(
value: '$likeCount',
value: '${compactFormat(likeCount).value}'
'${compactFormat(likeCount).suffix}',
supplemental: '',
label: 'likes',
);
Expand Down