[Safari] evaluating new constructorName

[rostopira]

Code to reproduce:

import 'dart:html';

void main() {
  querySelector('#output').text = 'Your Dart app is running.';
  final pc = new RtcPeerConnection(const {
    'iceServers': [
      {'urls':'stun:stun.l.google.com:19302'},
      {'urls':'stun:stun1.l.google.com:19302'},
      {'urls':'stun:stun2.l.google.com:19302'},
      {'urls':'stun:stun3.l.google.com:19302'},
      {'urls':'stun:stun4.l.google.com:19302'},
    ]
  });
}

Tried on dart 2.4 and 2.5. Works fine in chrome, error in safari only
Logs:

[Log] Unhandled error detected in the injected client.js script. (client.js, line 2565)

You can disable this script in webdev by passing --no-injected-client if it
is preventing your app from loading, but note that this will also prevent
all debugging and hot reload/restart functionality from working.

The original error is below, please file an issue at
https://github.com/dart-lang/webdev/issues/new and attach this output:

Error: undefined is not a constructor (evaluating 'new constructorName(html_common.convertDartToNative_SerializedScriptValue(rtcIceServers))')
new@http://localhost:53322/packages/build_web_compilers/src/dev_compiler/dart_sdk.js:88544:35
main$@http://localhost:53322/main.ddc.js:43:40
http://localhost:53322/dwds/src/injected/client.js:27433:16
http://localhost:53322/dwds/src/injected/client.js:25927:39
http://localhost:53322/dwds/src/injected/client.js:3110:17
call$2@http://localhost:53322/dwds/src/injected/client.js:11704:22
call$1@http://localhost:53322/dwds/src/injected/client.js:11690:38
_rootRunUnary@http://localhost:53322/dwds/src/injected/client.js:3389:24
runUnary$2$2@http://localhost:53322/dwds/src/injected/client.js:13083:190
call$0@http://localhost:53322/dwds/src/injected/client.js:12084:73
_Future__propagateToListeners@http://localhost:53322/dwds/src/injected/client.js:3199:110
_complete$1@http://localhost:53322/dwds/src/injected/client.js:11909:40
complete$1@http://localhost:53322/dwds/src/injected/client.js:11756:21
complete$1@http://localhost:53322/dwds/src/injected/client.js:11657:36
_asyncReturn@http://localhost:53322/dwds/src/injected/client.js:3083:27
http://localhost:53322/dwds/src/injected/client.js:8420:36
http://localhost:53322/dwds/src/injected/client.js:3110:17
call$2@http://localhost:53322/dwds/src/injected/client.js:11704:22
call$1@http://localhost:53322/dwds/src/injected/client.js:11690:38
_rootRunUnary@http://localhost:53322/dwds/src/injected/client.js:3389:24
runUnary$2$2@http://localhost:53322/dwds/src/injected/client.js:13083:190
call$0@http://localhost:53322/dwds/src/injected/client.js:12084:73
_Future__propagateToListeners@http://localhost:53322/dwds/src/injected/client.js:3199:110
call$0@http://localhost:53322/dwds/src/injected/client.js:12007:38
_rootRun@http://localhost:53322/dwds/src/injected/client.js:3374:22
run$1$1@http://localhost:53322/dwds/src/injected/client.js:13074:166
runGuarded$1@http://localhost:53322/dwds/src/injected/client.js:12999:21
call$0@http://localhost:53322/dwds/src/injected/client.js:13247:37
_microtaskLoop@http://localhost:53322/dwds/src/injected/client.js:3253:27
_startMicrotaskLoop@http://localhost:53322/dwds/src/injected/client.js:3259:25
call$1@http://localhost:53322/dwds/src/injected/client.js:11580:15
invokeClosure@http://localhost:53322/dwds/src/injected/client.js:1206:32
http://localhost:53322/dwds/src/injected/client.js:1225:24

[jakemac53]

This looks like a DDC issue, moving to the SDK repo.

There is another weird thing happening here where we captured the error in our client.js script error handler even though it was an application error which shouldn't happen and we will need to look into.

[Markzipan]

The issue's with this line within the SDK:

      let constructorName = window[dart.str(html_common.Device.propertyPrefix) + "RTCPeerConnection"];

html_common.Device.propertyPrefix is returning 'webkit'. Turns out only Chrome accepts 'webkitRTCPeerConnection'. AFAIK, all browsers will accept window["RTCPeerConnection"], so we should just use that.

Fix out at: https://dart-review.googlesource.com/c/sdk/+/116941

[rostopira]

Any updates? It's blocker for me

[Markzipan]

We're currently testing the fix - unfortunately its run is being blocked by some seemingly unrelated errors. This change will be in soon after we verify that nothing weird breaks.