Skip to content

skip files with only known annotation names #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 15, 2025
Merged

Conversation

jakemac53
Copy link
Contributor

Previously we would bail out early for files with no top level annotations, this also skips well known annotations (although it isn't perfect, and assumes people aren't shadowing these names).

Copy link
Contributor

@davidmorgan davidmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Some tests are failing--I guess because they are checking failures and so have no annotation, so the fix should be to add an annotation :) PTAL.

@davidmorgan
Copy link
Contributor

LG, thanks!

@jakemac53 jakemac53 merged commit b347ce4 into master Jul 15, 2025
12 checks passed
@jakemac53 jakemac53 deleted the skip-known-annotations branch July 15, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants