Skip to content

Conversation

@drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Jul 25, 2021

I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/

Summary

[store] feature: add SledVarTypeTree to store more than one types of key-value in one sled::Tree.

SledVarTypeTree is a candidate as raft state machine store.
Storing all state(such as last applied log index or internal seq number counter) in one tree makes transactional update or snapshot creation much easier.

Changelog

  • New Feature

Related Issues

#271

#1080

…key-value in one sled::Tree.

SledVarTypeTree is a candidate as raft state machine store.
Storing all state(such as last applied log index or internal seq number counter) in one tree makes transactional update or snapshot creation much easier.
@drmingdrmer drmingdrmer added this to the v0.5 milestone Jul 25, 2021
@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Jul 25, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

3 similar comments
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@drmingdrmer drmingdrmer marked this pull request as ready for review July 25, 2021 09:26
@codecov-commenter
Copy link

Codecov Report

Merging #1181 (8a9ae22) into master (a8b1682) will increase coverage by 0%.
The diff coverage is 94%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #1181    +/-   ##
=======================================
  Coverage      70%     71%            
=======================================
  Files         443     446     +3     
  Lines       25799   26330   +531     
=======================================
+ Hits        18215   18713   +498     
- Misses       7584    7617    +33     
Impacted Files Coverage Δ
fusestore/store/src/meta_service/state_machine.rs 90% <ø> (ø)
fusestore/store/src/meta_service/raft_types.rs 75% <60%> (-25%) ⬇️
...estore/store/src/meta_service/sled_vartype_tree.rs 91% <91%> (ø)
fusestore/store/src/meta_service/sledkv.rs 94% <94%> (ø)
...e/store/src/meta_service/sled_vartype_tree_test.rs 96% <96%> (ø)
common/runtime/src/runtime_test.rs 53% <0%> (-21%) ⬇️
...pelines/transforms/transform_aggregator_partial.rs 87% <0%> (-2%) ⬇️
fusestore/store/src/meta_service/raftmeta.rs 78% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8b1682...8a9ae22. Read the comment docs.

@dantengsky dantengsky merged commit 62603da into databendlabs:master Jul 25, 2021
@drmingdrmer drmingdrmer deleted the vtree branch July 25, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants