-
Notifications
You must be signed in to change notification settings - Fork 824
Support engine options and refactor github engine #3542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support engine options and refactor github engine #3542
Conversation
Thanks for the contribution! Please review the labels and make any necessary changes. |
d5626b1
to
e14163c
Compare
Codecov Report
@@ Coverage Diff @@
## main #3542 +/- ##
======================================
- Coverage 60% 60% -1%
======================================
Files 624 630 +6
Lines 34787 34923 +136
======================================
+ Hits 21203 21285 +82
- Misses 13584 13638 +54
Continue to review full report at Codecov.
|
4043e12
to
de8e1e3
Compare
Signed-off-by: ye.sijun <[email protected]>
de8e1e3
to
fd40fdf
Compare
use crate::storages::StorageContext; | ||
use crate::storages::Table; | ||
|
||
pub enum GithubTableType { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Abstraction!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ls +1!
/LGTM |
Wait for another reviewer approval |
CI Passed |
Looks great, thank you @junnplus ! |
I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/
Summary
engine_options
field toDatabaseMeta
andTableMeta
table_engine_github_enabled
config flag todatabase_engine_github_enabled
GITHUB
engine to replaceGITHUB_REPO_XXX_TABLE_ENGINE
table enginetodo:
Changelog
Related Issues
Fixes #issue
Test Plan
Unit Tests
Stateless Tests