Skip to content

Conversation

@junnplus
Copy link
Contributor

@junnplus junnplus commented Dec 21, 2021

I hereby agree to the terms of the CLA available at: https://databend.rs/policies/cla/

Summary

Summary about this PR

Changelog

  • New Feature

Related Issues

Fixes #3561

Test Plan

  • Unit Tests
  • Stateless Tests

@databend-bot databend-bot added the pr-feature this PR introduces a new feature to the codebase label Dec 21, 2021
@databend-bot
Copy link
Member

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@vercel
Copy link

vercel bot commented Dec 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/2XE1R3hZRD2ZQ3VQTen5SHMxrJqd
✅ Preview: Canceled

[Deployment for 472eed0 canceled]

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #3573 (e0bb8ab) into main (5f56470) will increase coverage by 0%.
The diff coverage is 66%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3573   +/-   ##
=====================================
  Coverage     61%     61%           
=====================================
  Files        631     634    +3     
  Lines      34921   34983   +62     
=====================================
+ Hits       21308   21398   +90     
+ Misses     13613   13585   -28     
Impacted Files Coverage Δ
common/planners/src/plan_node.rs 45% <0%> (-1%) ⬇️
common/planners/src/plan_rewriter.rs 45% <0%> (-1%) ⬇️
query/src/catalogs/impls/immutable_catalog.rs 45% <ø> (ø)
query/src/databases/github/github_database.rs 0% <0%> (ø)
query/src/interpreters/interpreter_factory.rs 36% <0%> (-3%) ⬇️
query/src/sql/sql_statement.rs 33% <0%> (-1%) ⬇️
common/planners/src/plan_show_create_database.rs 42% <42%> (ø)
query/src/databases/database.rs 75% <66%> (-25%) ⬇️
...c/sql/statements/statement_show_create_database.rs 75% <75%> (ø)
query/src/databases/system/system_database.rs 91% <83%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f56470...e0bb8ab. Read the comment docs.

@junnplus junnplus force-pushed the show-create-database branch from e0bb8ab to 472eed0 Compare December 21, 2021 08:10
@junnplus junnplus marked this pull request as ready for review December 21, 2021 08:13
@junnplus junnplus requested a review from BohuTANG as a code owner December 21, 2021 08:13
@BohuTANG
Copy link
Member

/lgtm

Thank you @junnplus !

@databend-bot
Copy link
Member

Wait for another reviewer approval

@BohuTANG BohuTANG merged commit 502092f into databendlabs:main Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Show create database statement

4 participants