Skip to content

*: Rename storage.disk to storage.fs #4740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2022
Merged

*: Rename storage.disk to storage.fs #4740

merged 4 commits into from
Apr 7, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Apr 7, 2022 •
edited
Loading

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Fix #4449

Changelog

  • Improvement

@Xuanwo Xuanwo requested a review from BohuTANG as a code owner April 7, 2022 11:25
@vercel
Copy link

vercel bot commented Apr 7, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/databend/databend/GrHWiy3wBRaw83qABE1SP7gL79gv
✅ Preview: https://databend-git-fork-xuanwo-rename-disk-to-fs-databend.vercel.app

[Deployment for 37d2a71 canceled]

@mergify
Copy link
Contributor

mergify bot commented Apr 7, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@Xuanwo Xuanwo linked an issue Apr 7, 2022 that may be closed by this pull request
Proposal: Rename storage.disk to storage.fs #4449
Closed
@Xuanwo
Fix build
6e254c0 
Signed-off-by: Xuanwo <[email protected]>
@Xuanwo Xuanwo requested review from dantengsky and sundy-li April 7, 2022 12:55
sundy-li
sundy-li approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@sundy-li sundy-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

BohuTANG
BohuTANG approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@BohuTANG BohuTANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@BohuTANG BohuTANG merged commit 2d482fd into databendlabs:main Apr 7, 2022
@Xuanwo Xuanwo deleted the rename-disk-to-fs branch April 10, 2022 03:21
@junnplus junnplus mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BohuTANG BohuTANG BohuTANG approved these changes

@sundy-li sundy-li sundy-li approved these changes

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Proposal: Rename storage.disk to storage.fs

4 participants

@Xuanwo @BohuTANG @sundy-li @databend-bot