Skip to content

ci: Make macOS checks optional #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 10, 2022
Merged

ci: Make macOS checks optional #5884

merged 5 commits into from
Jun 10, 2022

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jun 10, 2022 •
edited
Loading

Signed-off-by: Xuanwo [email protected]

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Implement #5880

This PR:

  • Make macOS checks optional, so we can merge a PR without waiting for macOS.
  • Remove requirement of check before embarking into merge queue, reduce the time for mergeing
  • Remove requirement of CI check, so all tasks can run concurrently.

Changelog

  • Build/Testing/CI

@vercel
Copy link

vercel bot commented Jun 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jun 10, 2022 at 6:00AM (UTC)

@Xuanwo Xuanwo marked this pull request as ready for review June 10, 2022 05:29
@mergify
Copy link
Contributor

mergify bot commented Jun 10, 2022

Thanks for the contribution!
I have applied any labels matching special text in your PR Changelog.

Please review the labels and make any necessary changes.

@mergify mergify bot added the pr-build this PR changes build/testing/ci steps label Jun 10, 2022
@BohuTANG
Copy link
Member

BohuTANG commented Jun 10, 2022 •
edited
Loading

There is a question:build_macos(or others related to macOS) is in high priority; it will block other tasks.
image

@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 10, 2022

What's the meaning of build_macos(or others related to macOS) is in high priority? macOS has it's only runners and not shared with other tasks.

@Xuanwo Xuanwo requested review from everpcpc, BohuTANG and PsiACE June 10, 2022 06:22
@Xuanwo
Copy link
Member Author

Xuanwo commented Jun 10, 2022 •
edited
Loading

This PR changed mergify's config, so mergify can't help us merge this PR, we need to merge it by hand.

@BohuTANG BohuTANG merged commit e4485d9 into databendlabs:main Jun 10, 2022
@Xuanwo Xuanwo deleted the make-macos-optional branch June 10, 2022 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everpcpc everpcpc Awaiting requested review from everpcpc

@BohuTANG BohuTANG Awaiting requested review from BohuTANG

1 more reviewer

@PsiACE PsiACE PsiACE approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
pr-build this PR changes build/testing/ci steps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Xuanwo @BohuTANG @PsiACE @databend-bot