Skip to content

Conversation

@Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jul 14, 2022

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

feat: Allow COPY and CREATE STAGE from public read buckets without credentials

This PR will make the following query works:

COPY INTO ontime_mini FROM 's3://repo.databend.rs/dataset/stateful/ontime_2006_100000.csv' 
    FILE_FORMAT = ( type = 'CSV' field_delimiter = ',' record_delimiter = '\n' skip_header = 1 );

Xuanwo added 3 commits July 14, 2022 14:15
@vercel
Copy link

vercel bot commented Jul 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 14, 2022 at 6:39AM (UTC)

@mergify mergify bot added the pr-feature this PR introduces a new feature to the codebase label Jul 14, 2022
@BohuTANG
Copy link
Member

Can we add a stateful test for it with minio?

@Xuanwo
Copy link
Member Author

Xuanwo commented Jul 14, 2022

Can we add a stateful test for it with minio?

We will continue those work after #6599

I plan to introduce better and fine-grained stateful test cases that covers all COPY and STAGE related cases.

@Xuanwo Xuanwo requested review from BohuTANG and PsiACE July 14, 2022 06:40
@BohuTANG BohuTANG merged commit df68a1d into databendlabs:main Jul 14, 2022
@Xuanwo Xuanwo deleted the allow-read-public branch July 14, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature this PR introduces a new feature to the codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants