Skip to content

Conversation

@sundy-li
Copy link
Member

I hereby agree to the terms of the CLA available at: https://databend.rs/dev/policies/cla/

Summary

Summary about this PR

  1. fix binder create table with lower case column name
  2. add TEXT, CHARACTER token

Fixes #issue

@vercel
Copy link

vercel bot commented Jul 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
databend ⬜️ Ignored (Inspect) Jul 30, 2022 at 2:36AM (UTC)

@sundy-li sundy-li requested review from leiysky and xudong963 July 29, 2022 08:35
@mergify mergify bot added the pr-bugfix this PR patches a bug in codebase label Jul 29, 2022
Copy link
Contributor

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parser-related golden test results need to update.

@Xuanwo
Copy link
Member

Xuanwo commented Jul 29, 2022

Following failed statements:
---------------------------------------------
Failed to execute. Collected info: 1105 (HY000): Code: 1005, displayText = error: 
  --> SQL:1:35
  |
1 | create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
  |                                   ^^ expected `(`, `UNION`, `EXCEPT`, `INTERSECT`, or `SELECT`

.

Parsed Statement
    at_line: 61,
    s_type: Statement: ok, type: None,
    suite_name: gen/02_function/02_0043_function_char,
    text:
        create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
    results: [],
    runs_on: {'mysql', 'clickhouse', 'http'},
---------------------------------------------
Expected: statement ok must get success response, not error code in response
Message: 
Parsed Statement
    at_line: 61,
    s_type: Statement: ok, type: None,
    suite_name: gen/02_function/02_0043_function_char,
    text:
        create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
    results: [],
    runs_on: {'mysql', 'clickhouse', 'http'},
---------------------------------------------
Failed to execute. Collected info: Orig exception: Code: 1005, displayText = error: 
  --> SQL:1:35
  |
1 | create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
  |                                   ^^ expected `(`, `UNION`, `EXCEPT`, `INTERSECT`, or `SELECT`

.

Parsed Statement
    at_line: 61,
    s_type: Statement: ok, type: None,
    suite_name: gen/02_function/02_0043_function_char,
    text:
        create table db1.t as SELECT CHAR(77,121,83,81,76) AS hello;
    results: [],
    runs_on: {'mysql', 'clickhouse', 'http'},

@Xuanwo
Copy link
Member

Xuanwo commented Jul 30, 2022

@mergify update

@mergify
Copy link
Contributor

mergify bot commented Jul 30, 2022

update

✅ Branch has been successfully updated

@mergify mergify bot merged commit 94af6a2 into databendlabs:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix this PR patches a bug in codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants