Skip to content

Conversation

@shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Sep 29, 2025

Changes

This PR adds support for ML experiments to direct deployment, keeping the behaviour the same as the current Terraform implementation.

Why

To make migration to direct possible and seamless.

Tests

New integration test.

- Add ResourceExperiment adapter implementing CRUD operations for MLflow experiments
- Add experiments to SupportedResources in direct deployment bundle
- Add acceptance test for experiment deployment in both terraform and direct modes
- Enable creating, updating, and deleting experiments via direct API calls

This allows experiments to be deployed using DATABRICKS_BUNDLE_ENGINE=direct-exp,
providing an alternative to the terraform-based deployment approach.
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Sep 29, 2025

Run: 18160547665

Env ✅​pass 🔄​flaky 🙈​skip
✅​ aws linux 320 536
✅​ aws windows 321 535
✅​ aws-ucws linux 433 433
✅​ aws-ucws windows 434 432
🔄​ azure linux 319 1 535
✅​ azure windows 321 534
✅​ azure-ucws linux 433 432
✅​ azure-ucws windows 434 431
✅​ gcp linux 319 537
✅​ gcp windows 320 536
Test Name azure linux
TestSyncIncrementalSyncPythonNotebookDelete 🔄​flaky

@denik
Copy link
Contributor

denik commented Sep 29, 2025

Can we enable acceptance/bundle/deploy/mlops-stacks/ ?

Copy link
Contributor

@denik denik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Same suggestion on test organization as in https://github.com/databricks/cli/pull/3670/files#r2393785138 (can be a follow up).


func (*ResourceExperiment) FieldTriggers() map[string]deployplan.ActionType {
return map[string]deployplan.ActionType{
"name": deployplan.ActionTypeUpdate,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a link to corresponding TF code would be helpful there.

@shreyas-goenka shreyas-goenka merged commit 58479e3 into main Oct 1, 2025
12 of 13 checks passed
@shreyas-goenka shreyas-goenka deleted the direct-experiments branch October 1, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants