-
Notifications
You must be signed in to change notification settings - Fork 111
Add support for experiments in direct deployment #3669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add ResourceExperiment adapter implementing CRUD operations for MLflow experiments - Add experiments to SupportedResources in direct deployment bundle - Add acceptance test for experiment deployment in both terraform and direct modes - Enable creating, updating, and deleting experiments via direct API calls This allows experiments to be deployed using DATABRICKS_BUNDLE_ENGINE=direct-exp, providing an alternative to the terraform-based deployment approach.
|
|
Can we enable acceptance/bundle/deploy/mlops-stacks/ ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Same suggestion on test organization as in https://github.com/databricks/cli/pull/3670/files#r2393785138 (can be a follow up).
|
|
||
| func (*ResourceExperiment) FieldTriggers() map[string]deployplan.ActionType { | ||
| return map[string]deployplan.ActionType{ | ||
| "name": deployplan.ActionTypeUpdate, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a link to corresponding TF code would be helpful there.
Changes
This PR adds support for ML experiments to direct deployment, keeping the behaviour the same as the current Terraform implementation.
Why
To make migration to direct possible and seamless.
Tests
New integration test.