Skip to content

fix column ddl bug #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix column ddl bug #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/databricks/sqlalchemy/_ddl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import logging
import re

from sqlalchemy.sql import compiler, sqltypes
import logging

logger = logging.getLogger(__name__)

Expand Down Expand Up @@ -68,7 +69,15 @@ def get_column_specification(self, column, **kwargs):
See comments in test_suite.py. We may implement implicit IDENTITY using this
feature in the future, similar to the Microsoft SQL Server dialect.
"""
if column is column.table._autoincrement_column or column.autoincrement is True:
is_autoincrement = bool(column.autoincrement)
if (
column.table is not None # column.table can be None
and not is_autoincrement
):
if column is column.table._autoincrement_column:
is_autoincrement = True

if is_autoincrement:
logger.warning(
"Databricks dialect ignores SQLAlchemy's autoincrement semantics. Use explicit Identity() instead."
)
Expand Down