Add --disable-assertions option to skip all assertions during compilation and execution #2024
+493
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…tion and execution
TerukiUeno
force-pushed
the
add_option_to_skip_all_assertions
branch
from
09047c6 to
b9ff7c3
Compare
…nstead of excluding them
|
/gcbrun |
kolina
requested changes
Oct 1, 2025
|
/gcbrun |
kolina
requested changes
Oct 3, 2025
| operations: [], | ||
| tests: [], | ||
| notebooks: [], | ||
| projectConfig: { |
There was a problem hiding this comment.
I think we should store the value of disableAssertions here
| type: "assertion" | ||
| } | ||
| ], | ||
| projectConfig: { |
| const npmCacheDir = tmpDirFixture.createNewTmpDir(); | ||
| const workflowSettingsPath = path.join(projectDir, "workflow_settings.yaml"); | ||
| const packageJsonPath = path.join(projectDir, "package.json"); | ||
| suite("disable-assertions flag excludes assertions", ({ beforeEach }) => { |
There was a problem hiding this comment.
I'd also add a test with this flag defined in workflow_settings.yaml
| expect(afterFormatCheckResult.stdout).contains("All files are formatted correctly"); | ||
| }); | ||
|
|
||
| suite("disable-assertions flag excludes assertions", ({ beforeEach }) => { |
There was a problem hiding this comment.
These tests seem to be failing at the moment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1984
Solution
This PR introduces a new
--disable-assertionscommand-line flag that allows users to completely disable all assertions during compilation and execution. This includes both manual assertions (defined withtype: "assertion") and built-in inline assertions (uniqueKey,nonNull, androwConditions).Key Implementation Details:
CLI Flag: Added
--disable-assertionsoption to bothcompileandruncommands with the description: "Disables all assertions including built-in assertions (uniqueKey, nonNull, rowConditions) and manual assertions (type: assertion)."Core Integration: The flag is passed through the compilation pipeline:
ProjectConfigOptions.disableAssertions→ProjectConfig.disableAssertions→Session.projectConfig.disableAssertionsAssertion Disabling Logic: When disableAssertions is true, all assertions (both manual and inline) are automatically marked as
disabled: trueduring their construction phase.Test
Verify that
bazel test //core/...passesEnsure
./scripts/lintpassesTest the complete workflow by running both
./scripts/run compile --disable-assertionsand./scripts/run run --disable-assertions --dry-runon a personal project, confirming that:type: "assertion") are properly disableduniqueKey,nonNull,rowConditions) are properly disabled