Skip to content

Conversation

@treff7es
Copy link
Contributor

@treff7es treff7es commented Nov 5, 2025

Set proper user agent for Bigquery client calls

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Nov 5, 2025
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ngestion/source/bigquery_v2/bigquery_connection.py 66.66% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (66.66%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 5, 2025
Follows Google's recommended format:
"<prod_name>/ver (GPN:<company name>; <other comments>)"
"""
return ClientInfo(user_agent=f"DataHub/{__version__} (GPN:DataHub)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC in other similar cases, we use some nice version

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 11, 2025
@treff7es treff7es merged commit 2557aa5 into master Nov 11, 2025
68 of 69 checks passed
@treff7es treff7es deleted the fix_biquery_user_agent branch November 11, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ingestion PR or Issue related to the ingestion of metadata pending-submitter-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants