CNDB-15990: Avoid varargs allocations in atomicMoveWithFallback #2124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
eolivelli
requested changes
Nov 14, 2025
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
Patch is missing unit tests
are there already unit tests that covers the methods you are changing ?
| try | ||
| { | ||
| Files.copy(from, to, option); | ||
| Files.copy(from, to, new CopyOption[] { option }); |
There was a problem hiding this comment.
we still allocate a new array here ?
Author
There was a problem hiding this comment.
Yes there already are unit tests that cover the methods I've changed. https://github.com/datastax/cassandra/blob/main/test/unit/org/apache/cassandra/io/util/PathUtilsTest.java
Fixed the unnecessary alocation.
|
✔️ Build ds-cassandra-pr-gate/PR-2124 approved by ButlerApproved by Butler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the issue
https://github.com/riptano/cndb/issues/15990
What does this PR fix and why was it fixed
What: Eliminates unnecessary array allocations in PathUtils.atomicMoveWithFallback() by pre-allocating CopyOption[] arrays as static constants.
Why: JFR profiling showed this method was a memory allocation hotspot during RemoteFileCache preloading. Each call to Files.move() with varargs parameters created new arrays, causing excessive GC pressure.