Address::compare() fixed #234
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some IPv4 addresses could not be found in IOWorker::PoolMap instance because Address::compare() method was broken on Windows x64.
|
Hi @ybainier, thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. Sincerely, |
|
Thank you @ybainier for signing the Contribution License Agreement. Cheers, |
…which is a C++11 type
|
@ybainier Great find! That's a huge unsigned subtract fail. Thanks. I would almost prefer using: |
|
That's clever and looks better. |
|
Change landed in b296030. Thanks a ton for finding the issue and providing a fix. |
mikefero
pushed a commit
that referenced
this pull request
Jul 1, 2019
…234) * Fix header include guards * Move cassconfig.hpp.in to driver_config.hpp.in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some IPv4 addresses could not be found in
IOWorker::PoolMapinstance becauseAddress::compare()method was broken on Windows x64.