344: Make libssh2 optional when building tests #259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 19, 2016 17:28
- If libssh2 is not found integration tests can only be run against server running locally
mikefero
changed the title
CMakeLists.txt
Outdated
| option(CASS_BUILD_DOCS "Build documentation" OFF) | ||
| option(CASS_BUILD_TESTS "Build tests" OFF) | ||
| option(CASS_BUILD_INTEGRATION_TESTS "Build tests" OFF) | ||
| option(CASS_BUILD_UNIT_TESTS "Build tests" OFF) |
There was a problem hiding this comment.
Maybe these should say "Build integration tests" and "Build unit tests"?
There was a problem hiding this comment.
Good call; that is why you shouldn't copy and paste.
mpenick
added a commit
that referenced
this pull request
Mar 3, 2016
344: Make libssh2 optional when building tests
mikefero
added a commit
that referenced
this pull request
Jul 1, 2019
DSE v1.9.0 release preparations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CCM commands can now be run locally libssh2 can be considered optional. This change will present a status message if -DCASS_USE_LIBSSH2=ON and cannot be found; indicating libssh2/remote commands will be disabled. This change also allows for the building of either the integration (libssh2 optional), unit tests, or both.