Skip to content

CPP-967 PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare fails with some versions of Cassandra #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2023
Merged

CPP-967 PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare fails with some versions of Cassandra #549

merged 1 commit into from
Jul 28, 2023

Conversation

@absurdfarce
Copy link
Collaborator

@absurdfarce absurdfarce commented Jul 28, 2023

No description provided.

Implement support for single version check across multiple major.mino…
fa09638 
…rs with checking

for patch levels within the matching major.minor only.  Also generalized the code
(and the messaging) somewhat.
@absurdfarce
Copy link
Collaborator Author

absurdfarce commented Jul 28, 2023

With this change I now see the following:

$ ./cassandra-integration-tests --gtest_filter=PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare --version=3.11.12                                                                                                                                                             
DSE Category Will be Ignored: DSE is not enabled [--dse]                                                                                                                                                              
Starting DataStax C/C++ Driver Integration Test                                                                                                                                                                       
  v2.16.2                                                                                                                                                                                                             
  libuv v1.44.2                                                                                                                                                                                                       
  Logging driver messages                                                                                                                                                                                             
  Apache Cassandra Version: 3.11.12                                                                                                                                                                                   
  CCM Cluster Prefix: cpp-driver                                                                                                                                                                                      
Category: Cassandra                                                                                                                                                                                                   
Note: Google Test filter = PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare:-*_DSE_*                                                                                                  
[==========] Running 1 test from 1 test case.                                                                                                                                                                         
[----------] Global test environment set-up.                                                                                                                                                                          
[----------] 1 test from PreparedTests                                                                     
[ RUN      ] PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare              
[ SKIPPED  ] Unsupported for Apache Cassandra Version 3.11.12: Server version is >= the required version 3.11.12
[       OK ] PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare (4498 ms)    
[----------] 1 test from PreparedTests (4498 ms total)                                                     
                                                                                                           
[----------] Global test environment tear-down                                                             
[==========] 1 test from 1 test case ran. (4498 ms total)                                                                                                                                                             
[  PASSED  ] 1 test. 

$ ./cassandra-integration-tests --gtest_filter=PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare --version=3.11.11                             
DSE Category Will be Ignored: DSE is not enabled [--dse]                              
Starting DataStax C/C++ Driver Integration Test                                                            
  v2.16.2                                                                                                  
  libuv v1.44.2                                                                                            
  Logging driver messages                                                                                  
  Apache Cassandra Version: 3.11.11                                                                        
  CCM Cluster Prefix: cpp-driver                                                                           
Category: Cassandra                        
Note: Google Test filter = PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare:-*_DSE_*
[==========] Running 1 test from 1 test case.       
[----------] Global test environment set-up.                                                               
[----------] 1 test from PreparedTests
[ RUN      ] PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare              
[       OK ] PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDChangesDuringReprepare (4928 ms)    
[----------] 1 test from PreparedTests (4928 ms total)              
                                                                                                           
[----------] Global test environment tear-down
[==========] 1 test from 1 test case ran. (4928 ms total)
[  PASSED  ] 1 test.

I see similar results when using 4.0.2 vs. 4.0.1.

@absurdfarce
Copy link
Collaborator Author

absurdfarce commented Jul 28, 2023

With this change I'm now seeing successful integration test runs on CentOS 7 with 4.0, 3.11 and 3.0.

@absurdfarce absurdfarce requested a review from weideng1 July 28, 2023 07:31
@absurdfarce absurdfarce merged commit 6bda881 into master Jul 28, 2023
@absurdfarce absurdfarce deleted the cpp967 branch July 28, 2023 19:36
weideng1 pushed a commit that referenced this pull request Jul 29, 2023
@absurdfarce
CPP-967 PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDCha…
c5b1e4e 
…ngesDuringReprepare fails with some versions of Cassandra (#549)
weideng1 pushed a commit that referenced this pull request Aug 1, 2023
@absurdfarce
CPP-967 PreparedTests.Integration_Cassandra_FailFastWhenPreparedIDCha…
ee92ba3 
…ngesDuringReprepare fails with some versions of Cassandra (#549)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weideng1 weideng1 weideng1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@absurdfarce @weideng1