Skip to content

Add support to templating content with function #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 29, 2020
Merged

Add support to templating content with function #34

merged 2 commits into from
Sep 29, 2020

Conversation

@pranavwani
Copy link

@pranavwani pranavwani commented Sep 28, 2020

No description provided.

curran
curran approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I love how simple this is compared to the original PR. Thanks for the effort!

@curran curran merged commit 21cebdf into datavis-tech:master Sep 29, 2020
@curran
Copy link
Member

curran commented Sep 29, 2020

Released in https://github.com/datavis-tech/json-templates/releases/tag/v4.0.0

@pranavwani
Copy link
Author

pranavwani commented Sep 29, 2020 •
edited
Loading

Thanks, @curran for the support 🎉

@curran curran mentioned this pull request Oct 5, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curran curran curran approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pranavwani @curran