-
-
Notifications
You must be signed in to change notification settings - Fork 32
Add support for Vite v6 #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
+1 -- I would value this change as I am upgrading a legacy CRA app , and using Vite 6.0.1 and getting this error |
|
Great, waiting the approve and new version |
|
@davidmyersdev, is this project still maintained? I see you’re pretty active on other GitHub projects, we could do a fork if not. |
daomtthuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Just change package json for supporting Vite v6.
No impacts
|
Anyone has a published fork ? |
I'll try to give it a shot today, the CI workflow seems to be kinda broken, and I'd like for it to have a deployment workflow as well for transparency purposes :) I'm working on the CI workflow right now |
* ci: trigger workflow to check status * cleanup: update actions to latest versions and simplify caching * fix: ordering of actions * fix: respect packageManager field @ package.json * ci: update checkout action to v4 and simplify job dependencies * ci: update test-e2e runner to ubuntu-22.04 for os deps required by playwright
|
Ok, I've just published vite-plugin-node-polyfill at version Remember to update the dependency and the import, from To I'm happy to mark the package as deprecated if this repo comes back to life at some point 😄 |
I could not see the difference. For anyone with weary eyes like myself the fork is sans "s". |
davidmyersdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey all. Apologies for the delay on this. I've been a bit busy with other projects (as you've noticed) and just hadn't come back to this one yet. I'll kick off CI and merge if everything passes.
|
Hm... It looks like GitHub does not allow running CI on PRs from forks? I'll have to cherry-pick your commits onto a new branch to run tests, I think. |
|
Results of the CI run looks good. Merging it. |
|
Released in |
|
Hey! Sorry for the delayed reply on my side. I just deprecated the forked package 😄 Thank you!! |
Since the workaround in the issue #110 comment seems to work okay, this should do the trick.
Didn't bump the package version since you may want to update dependencies further before releasing it? :)
Fixes #110
Fixes #113
Note: If you're taking a look because this issue happened to you, I've published a fork of this repo as vite-plugin-node-polyfill with Vite v6 support 😄