Skip to content

Conversation

@barrenechea
Copy link
Contributor

@barrenechea barrenechea commented Dec 10, 2024

Since the workaround in the issue #110 comment seems to work okay, this should do the trick.

Didn't bump the package version since you may want to update dependencies further before releasing it? :)

Fixes #110
Fixes #113

Note: If you're taking a look because this issue happened to you, I've published a fork of this repo as vite-plugin-node-polyfill with Vite v6 support 😄

@daniel-lauri-walsh
Copy link

+1 -- I would value this change as I am upgrading a legacy CRA app , and using Vite 6.0.1 and getting this error

@aleksraiden
Copy link

Great, waiting the approve and new version

@barrenechea
Copy link
Contributor Author

@davidmyersdev, is this project still maintained? I see you’re pretty active on other GitHub projects, we could do a fork if not.

Copy link

@daomtthuan daomtthuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Just change package json for supporting Vite v6.
No impacts

@Sceat
Copy link

Sceat commented Jan 12, 2025

Anyone has a published fork ?

@barrenechea
Copy link
Contributor Author

Anyone has a published fork ?

I'll try to give it a shot today, the CI workflow seems to be kinda broken, and I'd like for it to have a deployment workflow as well for transparency purposes :) I'm working on the CI workflow right now

* ci: trigger workflow to check status

* cleanup: update actions to latest versions and simplify caching

* fix: ordering of actions

* fix: respect packageManager field @ package.json

* ci: update checkout action to v4 and simplify job dependencies

* ci: update test-e2e runner to ubuntu-22.04 for os deps required by playwright
@barrenechea
Copy link
Contributor Author

Ok, I've just published vite-plugin-node-polyfill at version 0.22.1 based off my fork. Just worked on the workflows and added the Vite v6 support. The build and publish logs are here.

Remember to update the dependency and the import, from

import { nodePolyfills } from "vite-plugin-node-polyfills";

To

import { nodePolyfills } from "vite-plugin-node-polyfill";

I'm happy to mark the package as deprecated if this repo comes back to life at some point 😄

@O-Mutt
Copy link

O-Mutt commented Jan 14, 2025

Ok, I've just published vite-plugin-node-polyfill at version 0.22.1 based off my fork. Just worked on the workflows and added the Vite v6 support. The build and publish logs are here.

Remember to update the dependency and the import, from

import { nodePolyfills } from "vite-plugin-node-polyfills";

To

import { nodePolyfills } from "vite-plugin-node-polyfill";

I'm happy to mark the package as deprecated if this repo comes back to life at some point 😄

I could not see the difference. For anyone with weary eyes like myself the fork is sans "s". polyfill vs polyfills

Copy link
Owner

@davidmyersdev davidmyersdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey all. Apologies for the delay on this. I've been a bit busy with other projects (as you've noticed) and just hadn't come back to this one yet. I'll kick off CI and merge if everything passes.

@davidmyersdev
Copy link
Owner

Hm... It looks like GitHub does not allow running CI on PRs from forks? I'll have to cherry-pick your commits onto a new branch to run tests, I think.

@davidmyersdev
Copy link
Owner

Results of the CI run looks good. Merging it.

@davidmyersdev davidmyersdev merged commit c40a478 into davidmyersdev:main Jan 19, 2025
@davidmyersdev
Copy link
Owner

Released in v0.23.0.

@barrenechea
Copy link
Contributor Author

Hey! Sorry for the delayed reply on my side. I just deprecated the forked package 😄

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Update to vite 6 Bug: Unable to use with vite 6.x without warning

8 participants