Skip to content

Conversation

meeuw
Copy link
Contributor

@meeuw meeuw commented Aug 18, 2018

Description

Don't align decimals for sql_format, fixes #635

Checklist

  • I've added this contribution to the changelog.md.
  • I've added my name to the AUTHORS file (or it's already there).

@codecov-io
Copy link

codecov-io commented Aug 18, 2018

Codecov Report

Merging #636 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #636      +/-   ##
=========================================
+ Coverage   77.54%   77.7%   +0.15%     
=========================================
  Files          26      26              
  Lines        2285    2287       +2     
=========================================
+ Hits         1772    1777       +5     
+ Misses        513     510       -3
Impacted Files Coverage Δ
mycli/main.py 76.08% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543e4b6...73f69e5. Read the comment docs.

@meeuw meeuw force-pushed the bugfix/no_align_decimals_sql_format branch from e7c3147 to db1cf6a Compare August 18, 2018 10:05
@meeuw meeuw force-pushed the bugfix/no_align_decimals_sql_format branch from db1cf6a to 73f69e5 Compare August 18, 2018 10:19
Copy link
Member

@tsroten tsroten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meeuw Nice update to the tests as well here 👍 🚀

@tsroten tsroten merged commit d513670 into master Aug 19, 2018
@tsroten tsroten deleted the bugfix/no_align_decimals_sql_format branch August 19, 2018 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[formatting] align_decimal preprocessor not wanted for sql-insert output formatter?

3 participants