File Explorer drag and drop to move files #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add drag and drop styling Some clean up before review
- Fix Shift-Click selection. It wasn't updating the selection properly, this has been broken since powell --> A couple of functions like handleItemBlur and handleItemFocus were unnecessary, just removed them. - Update selection after dropping - Emit signal for all renamed files
Member
Author
|
Replaced with #109 , which just uses ItemList and gets rid of SingleClickItemList |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Notebook UI: Drag and Drop to move #86
I didn't end up consolidating with ItemList - I was trying to use DraggableItemList which wasn't quite right since it has a lot of styling we don't need, was going to change to ItemList but then realized I'd have to do all the drag and drop styling again, figured I may just be wasting time.