Skip to content

Conversation

@mofojed
Copy link
Member

@mofojed mofojed commented Jul 28, 2021

workflow_dispatch action allows you to select the branch you want to execute the workflow from, however it doesn't let you select a PR that's currently in review if it's created from a fork.

By allowing a SHA to be input, we should be able to input the commit from the PR and it will publish from that.

I _think_ should be able to trigger it off a PR then
@mofojed mofojed requested a review from spasovski July 28, 2021 14:56
@mofojed mofojed self-assigned this Jul 28, 2021
Copy link
Contributor

@spasovski spasovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did some battle-testing of this yesterday. Worked great!

@mofojed mofojed merged commit 9be4c54 into deephaven:main Jul 29, 2021
@mofojed mofojed deleted the publish-sha branch July 29, 2021 20:01
@mofojed mofojed mentioned this pull request Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants