Show an error message if the API is not found #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
changed the title
Member
Author
|
Nevermind this only works in dev, not in a production build :( |
This now handles both cases where the URL for the API isn't found at all (no script loaded), or if an incorrect file is loaded (eg. a 404 file) and script doesn't initialize. Also a bit cleaner.
mofojed
commented
Jul 28, 2021
dsmmcken
reviewed
Jul 28, 2021
Contributor
dsmmcken
left a comment
dsmmcken
left a comment
There was a problem hiding this comment.
Unrelated, but why not fix the advanced filter creator error, there's an explicit proptype we have in the shim.
import { dh, PropTypes as DhPropTypes } from '@deephaven/jsapi-shim';
...
filters: PropTypes.arrayOf(DhPropTypes.FilterCondition).isRequired,
- Fix up AdvancedFilterCreatorSelectValueList PropType - Fix up styling of error message
Member
Author
|
Fixes #64 |
dsmmcken
approved these changes
Jul 30, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Write out an error message when the API can't load.
Since we depend on the API for our initialization (eg. ChartBuilder depends on
dh.plot.SeriesPlotStyle.*to initialize it's static types), we can't count on our app fully loading and/or executing our index.jsx entrypoint. It may be possible to style this to look better, but it may be a pain. I think this way gets the message across instead of just giving the user a blank screen.