Skip to content

feat: Add support for multiple outputs in ConditionalRouter #9271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mdrazak2001
Copy link
Contributor

Related Issues

Proposed Changes:

  • updated output field valdation and input to allow multiple values

How did you test it?

  • added unit tests
  • fixed breaking tests in test_conditional_router.py

Notes for the reviewer

Checklist

  • I have read the contributors guidelines and the code of conduct
  • I have updated the related issue with new insights and changes
  • I added unit tests and updated the docstrings
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I documented my code
  • I ran pre-commit hooks and fixed any issue

@mdrazak2001 mdrazak2001 requested review from a team as code owners April 20, 2025 07:43
@mdrazak2001 mdrazak2001 requested review from dfokina and vblagoje and removed request for a team April 20, 2025 07:43
@coveralls
Copy link
Collaborator

coveralls commented Apr 20, 2025

Pull Request Test Coverage Report for Build 14643637788

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 93 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+0.02%) to 90.519%

Files with Coverage Reduction New Missed Lines %
components/preprocessors/document_preprocessor.py 1 95.56%
components/generators/openai_dalle.py 3 93.48%
tools/serde_utils.py 3 92.5%
components/generators/azure.py 4 91.84%
components/generators/openai.py 4 95.74%
components/embedders/openai_text_embedder.py 6 88.68%
tools/tool.py 6 90.48%
components/tools/tool_invoker.py 9 90.44%
components/audio/whisper_remote.py 11 70.45%
components/routers/conditional_router.py 17 87.5%
Totals Coverage Status
Change from base Build 14532049680: 0.02%
Covered Lines: 10856
Relevant Lines: 11993

💛 - Coveralls

@sjrl sjrl removed the request for review from vblagoje April 22, 2025 13:36
@github-actions github-actions bot added the type:documentation Improvements on the docs label Apr 22, 2025
@mdrazak2001 mdrazak2001 requested a review from sjrl April 23, 2025 12:20
Copy link
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjrl sjrl enabled auto-merge (squash) April 24, 2025 14:12
@sjrl sjrl merged commit f974723 into deepset-ai:main Apr 24, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:tests type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ConditionalRouter to have multiple outputs per condition
3 participants