This repository was archived by the owner on May 21, 2025. It is now read-only.
Add SendPropIdentifier::from_const #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the clippy and test PR failures are both failing on master already: 0cd87a8 |
icewind1991
force-pushed
the
from_const
branch
from
b10f24f to
32d7360
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor API addition to allow making consts for SendProps without needing to figure out the original table/prop name.
This is like the existing
From<u64>impl; but marked const (sadly, Rust is still a long way off from const fns in traits rust-lang/rfcs#3490)