Skip to content

throw error message if the transaction doesn't exist #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 6, 2021
Merged

throw error message if the transaction doesn't exist #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
439092f
throw error message if the transaction doesnt exist
Sep 29, 2021
18cf0cf
fix tests
darbaoui Oct 6, 2021
379337f
Apply fixes from StyleCI
darbaoui Oct 6, 2021
9f1d4a0
Merge pull request #17 from devinweb/analysis-e7ZZpA
darbaoui Oct 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,8 @@
stopOnFailure="false"
>
<testsuites>
<testsuite name="Unit">
<directory suffix="Test.php">./tests/Unit</directory>
</testsuite>
<testsuite name="Feature">
<directory suffix="Test.php">./tests/Feature</directory>
<testsuite name="Package Test">
<directory suffix=".php">./tests/</directory>
</testsuite>
</testsuites>
<php>
Expand Down
3 changes: 2 additions & 1 deletion resources/lang/ar.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"failed_message": "حدث خطأ في عملية الدفع يرجى المحاولة مرة أخرى."
"failed_message": "حدث خطأ في عملية الدفع يرجى المحاولة مرة أخرى.",
"invalid_checkout_id": "checkout_id غير صالح"
}
5 changes: 5 additions & 0 deletions src/Support/TransactionBuilder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
namespace Devinweb\LaravelHyperpay\Support;

use Illuminate\Support\Arr;
use Illuminate\Validation\ValidationException;

class TransactionBuilder
{
Expand Down Expand Up @@ -60,6 +61,10 @@ public function findByIdOrCheckoutId($id)
$transaction_model = config('hyperpay.transaction_model');
$transaction = app($transaction_model)->whereId($id)->orWhere('checkout_id', $id)->first();

if (! $transaction) {
throw ValidationException::withMessages([__('invalid_checkout_id')]);
}

return $transaction;
}

Expand Down