Skip to content

Conversation

@devondragon
Copy link
Owner

This pull request introduces a new feature for handling user account deletion and profile cleanup, along with some refactoring and improvements in the codebase. The most important changes include the addition of a new event for pre-deletion operations, updates to the user service to handle account deletion or disabling, and documentation updates to reflect these changes.

New feature for user account deletion and profile cleanup:

  • README.md: Added a new section on handling user account deletion and profile cleanup, including enabling actual deletion and cleaning up related data. [1] [2]

Code refactoring and improvements:

Minor updates:

Copilot AI review requested due to automatic review settings April 13, 2025 21:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/main/java/com/digitalsanctuary/spring/user/service/UserService.java:196

  • Ensure that the eventPublisher is properly injected (e.g., via constructor injection) to avoid potential null pointer issues during event publishing.
private final ApplicationEventPublisher eventPublisher;

src/main/java/com/digitalsanctuary/spring/user/service/UserService.java:261

  • Please add test cases to cover both scenarios in deleteOrDisableUser method: when actuallyDeleteAccount is true (deletion path) and when it is false (disabling path).
public void deleteOrDisableUser(final User user) {

@devondragon devondragon merged commit 80f7c47 into main Apr 13, 2025
3 checks passed
@devondragon devondragon deleted the issue-175-BUG---Delete-User-Not-Cascading-to-BaseUserProfile-sub-classes branch April 13, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants