https://github.com/devondragon/SpringUserFramework/issues/2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devondragon
deleted the
issue-2-Add_support_for_configuring_CSRF_exclusions_URLs
branch
devondragon
added a commit
that referenced
this pull request
Oct 26, 2025
This commit addresses 4 critical security issues in password management: **Fix #1: Add password validation to /updatePassword endpoint** - Added passwordPolicyService.validate() call before saving password - Prevents users from setting weak passwords when updating - Enforces all policy rules including history, similarity, and complexity **Fix #2: Implement missing /savePassword endpoint** - Created SavePasswordDto for password reset with token - Implemented complete /savePassword endpoint with full validation - Added deletePasswordResetToken method to UserService - Added message keys for password reset flow - Fixes incomplete password reset functionality **Fix #3: Document password history behavior** - Added JavaDoc explaining null user parameter during registration - Documented that history checks only apply to existing users - Added clarifying comments in registration endpoint **Fix #4: Add transaction isolation for password history cleanup** - Added @transactional(isolation = SERIALIZABLE) to cleanUpPasswordHistory - Prevents race conditions during concurrent password changes - Added comprehensive JavaDoc documentation **Additional improvements:** - Cascade delete configuration for PasswordHistoryEntry (from earlier work) - LAZY fetch type optimization on both sides of relationship - All existing tests pass (372 tests) See IMPLEMENTATION_PLAN_PASSWORD_FIXES.md for detailed analysis and implementation plan. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.