Add backend routes for courses and classes #1013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason4193
force-pushed
the
1000-update-backend-route-for-courses-and-classes
branch
from
dd3fabc to
3348b07
Compare
jason4193
force-pushed
the
1000-update-backend-route-for-courses-and-classes
branch
2 times, most recently
from
a0febd1 to
2af047a
Compare
lhvy
approved these changes
Jul 10, 2025
Contributor
lhvy
left a comment
lhvy
left a comment
There was a problem hiding this comment.
Looks pretty good, minor feedback comments left. Would also suggest looking here and seeing if any of these status codes could be used for when your routes succeed: https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Status#successful_responses
lhvy
changed the title
Closed
lhvy
approved these changes
Jul 15, 2025
Contributor
lhvy
left a comment
lhvy
left a comment
There was a problem hiding this comment.
Looking good, really happy with the refactor. Just a few minor comments now.
jason4193
force-pushed
the
1000-update-backend-route-for-courses-and-classes
branch
from
7cbfdcc to
9674588
Compare
… function for update and remove class
jason4193
force-pushed
the
1000-update-backend-route-for-courses-and-classes
branch
from
a079698 to
9a98db7
Compare
lhvy
approved these changes
Jul 17, 2025
lhvy
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Add routes for adding and removing course * Update routes by moving validation to controller * Add route for update course colour * add OpenAPI for api-docs for backend using swagger library * Add ApiProperty for user's route * Add get route for courses and classes with update of routing urls * Update PUT request for setCourseColour to PATCH request * Update user routes to using AuthenticatedRequest Type * Add selectClass & removeClass route * Remove OpenAPI and Swagger Library, switched to use Postman * Update route for select and remove class * Remove unwanted routes with forwarding functions * Resolve usage of null and undefined * Resolve PR review comments * Slim down the Course and Class detail for graphql, and add validation function for update and remove class * Update routes returning status code * Refactor user.controller, move all business validation into service level * Remove duplicate getCourse request in addSelectedClass * Resolve issues on the PR code review * Resolve minor issue on function call, optimise prisma call * Resolve function name typo * Update service level function name corresponds to control level
lhvy
pushed a commit
that referenced
this pull request
Aug 31, 2025
* Add routes for adding and removing course * Update routes by moving validation to controller * Add route for update course colour * add OpenAPI for api-docs for backend using swagger library * Add ApiProperty for user's route * Add get route for courses and classes with update of routing urls * Update PUT request for setCourseColour to PATCH request * Update user routes to using AuthenticatedRequest Type * Add selectClass & removeClass route * Remove OpenAPI and Swagger Library, switched to use Postman * Update route for select and remove class * Remove unwanted routes with forwarding functions * Resolve usage of null and undefined * Resolve PR review comments * Slim down the Course and Class detail for graphql, and add validation function for update and remove class * Update routes returning status code * Refactor user.controller, move all business validation into service level * Remove duplicate getCourse request in addSelectedClass * Resolve issues on the PR code review * Resolve minor issue on function call, optimise prisma call * Resolve function name typo * Update service level function name corresponds to control level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🧾
Testing
By now, we testing our code by reading. Run them later for actual test.
Checklist
feature: for application feature improvement or new featuresbug: fixing something that previously wasn't workingdev: development-side related changesdocker: updates to the Docker codesetup: changes to the setup/infrastructure of the codebasetest: updates to internal testing